Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics separation merge: Step12 #32

Merged
merged 12 commits into from
Dec 26, 2017
Merged

Physics separation merge: Step12 #32

merged 12 commits into from
Dec 26, 2017

Conversation

llpcarson
Copy link
Contributor

From Don Stark
https://github.com/kellylittleblackdog/gmtb-gfsphysics

branch: seaice_separator_work_gfs

merged with master, bug-fixes, bit-for-bit match with baseline (theia)

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, too.

@climbfuji climbfuji changed the title Physics separation merge: Step11 Physics separation merge: Step12 Dec 26, 2017
Added subroutine names to 'end subroutine' statements.
@climbfuji
Copy link
Collaborator

Update: I made an additional commit to the PR that adds missing 'subroutine SUBROUTINE_NAME' statements to the 'end' statements in the seaice routines. This is needed for CCPP prebuild scripts to function properly. I tested the PR on Cheyenne (64-bit) for BFB identical results - all good. Will do the merge now.

@climbfuji climbfuji merged commit d1b0741 into NCAR:master Dec 26, 2017
climbfuji pushed a commit to climbfuji/ccpp-physics that referenced this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants